Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the subpixel jitter improvement I did for Tom. All of my changes are marked with a comment containing "Cloaked Games" so you can search and see what I did. I will summarize here:
The main change is I added a
spd_min
property to the camera, which is added to the speed of the camera each frame, basically ensuring it never moves smaller than thespd_min
. When this value is set to1
, the camera will never move a subpixel amount. This removes any visible subpixel jitter at the camera approaches its target, at the cost of the camera moving a bit faster overall and stopping more suddenly.However, my solution is probably not production ready. It is fully incompatible with animation curves due to them using displacement, not speed. To make this fix work, I bypassed several of the animation curves, and in fact combined the offset with the regular movement.* If you want to use my improvement, I recommend looking over my code and integrating it more thoroughly before sending to anyone else to use. I am happy to answer clarifying questions via Discord.
*I might recommend combining all the movement into a single step generally, and using the various animations only to calculate the target position. As it is, the several competing movement steps sometimes results in chaotic or jarring motion to my eyes. That is an overarching change out of the scope of this pull request, and dependent on Stann's design goals.